feat(mobile): dedicated mobile shell — bottom nav + create FAB + graph lock toggle#81
Merged
Merged
Conversation
…create FAB, graph lock toggle Not just "make the desktop UI fit" — a phone-first navigation model. - Bottom tab bar (phones): List · Graph · More. List first (the check-in-on- the-go default), Graph second; the rest (Dashboard/Table/Board/Gantt/Calendar/ Activity) live in a tidy "More" bottom sheet. Replaces the squeezed desktop tab strip on phones (the strip is now hidden md:flex / desktop+tablet only). - Create FAB (+) bottom-right on phones for non-guests (hidden in graph view, where the on-canvas grow flow creates nodes). - Graph lock/unlock toggle (phones): defaults to Locked so a touch pans the canvas and never accidentally drags a node or edge label; unlock to edit. Implemented as a d3.drag .filter() on both the node and edge-label drag behaviors, reading a live ref (no handler re-bind on toggle). Desktop is a no-op (interactionLocked is false there), so the grow flow etc. are unchanged. - Plumbed interactionLocked through SafeGraphVisualization → IGV. Tests: mobile-experience now asserts the bottom nav drives views + the lock defaults to Locked; mobile-views navigates via the bottom nav/More sheet. mobile specs 10/10; web typecheck clean; smoke 4/5 with grow-flow passing on isolated re-run (known local-DB flake; IGV change is desktop-noop). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🧪 Comprehensive Test Suite
Full-stack smoke gate runs in the CI workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Per feedback: don't just shrink the desktop UI — give phones a clear, consistent, app-like experience.
What
d3.drag.filter()on both drag behaviors via a live ref. Desktop is a no-op (interactionLockedfalse), so existing behavior/grow-flow is unchanged.Tests
mobile-experience: bottom nav present + drives views, More sheet lists secondary views, lock defaults to Locked.mobile-views: navigates via bottom nav/More sheet; all views still need no sideways scroll.