fix: de-flake grow-flow smoke test + Dashboard mobile label squeeze#82
Merged
Merged
Conversation
…hones
Flaky test (the grow-flow smoke gate):
- Wait for the force layout to SETTLE (poll a node's box until it stops moving)
before clicking the "+" grow icon — the icon rides on its node, so clicking it
mid-simulation (or while nodes overlap) was the historical flake.
- Retry the click→"Click empty space to grow" hint via expect.poll/toPass instead
of failing on a single swallowed click.
- Base the +1/-1 create/undo assertions on the GraphQL API (DB truth) instead of
the DOM .node/.edge count, which viewport culling makes unreliable; still assert
the user SEES the newly named node. 3/3 clean reseed+run cycles; smoke 5/5.
Dashboard view (mobile):
- The status breakdown used grid-cols-3 unconditionally; at 390px each card got so
narrow the status labels ("Planned"/"In Progress"/…) collapsed to ~4px and
vanished. Now grid-cols-2 sm:grid-cols-3.
Test guard:
- mobile-views now also fails on any multi-char label squeezed under ~12px
(verified: reverting the Dashboard fix makes the Dashboard case go red).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🧪 Comprehensive Test Suite
Full-stack smoke gate runs in the CI workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flaky test (grow-flow smoke gate)
toPassinstead of failing on one swallowed click..nodecount (viewport culling skews it); still assert the user sees the named node.Dashboard (mobile)
grid-cols-3unconditionally → at 390px the labels collapsed to ~4px and vanished. Nowgrid-cols-2 sm:grid-cols-3.Test guard
mobile-viewsnow also fails on any multi-char label squeezed under ~12px (verified red when the Dashboard fix is reverted). All other views audited at 390px against a 19-node graph: no overflow, no squeeze.