chore(web): dedupe SVG glow-filter construction (verified byte-identical)#90
Merged
Conversation
The node / node-menu / selected-node / edge glow effects each rebuilt the same animated SVG filter inline (4 near-identical ~30-line blocks). Extract a single module-level createGlowFilter(defs, id, color, opts) and call it from all four sites; they differ only in id, region, blur size, animation values and duration. Behavior-preserving — verified the generated <filter> defs are BYTE-IDENTICAL before/after (a temporary capture harness diffed node-glow + selected-node-glow; the edge-glow call passes the same literal params the inline block used). Smoke 5/5, node-inspector + node-expand-legibility diagnostics 3/3, typecheck + lint (0 errors) clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🧪 Comprehensive Test Suite
Full-stack smoke gate runs in the CI workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes the cleanup: the deferred glow-filter duplication, done with verification.
The node / node-menu / selected-node / edge glow effects each rebuilt the same animated SVG
<filter>inline (4 near-identical ~30-line blocks). Extracted one module-levelcreateGlowFilter(defs, id, color, opts); all four sites now call it, differing only in id, region, blur size, animation values, and duration.Verified behavior-preserving (not just "tests pass"): a temporary capture harness dumped the generated
<filter>defs from the live graph before and after the refactor —node-glow+selected-node-glowcame back byte-identical (diffempty). The edge-glow call passes the exact literal params the inline block used, and the filter structure is proven identical by that diff, so it's behavior-preserving by construction. (Filter-defs equality is a stronger check than pixel screenshots, which would just be SMIL-animation noise.)Verified: typecheck + lint (0 errors), smoke 5/5, node-inspector + node-expand-legibility diagnostics 3/3.
🤖 Generated with Claude Code