test(dismissal): verify the dialog-manager friction contract (Esc + click-outside)#93
Merged
Conversation
New @DiSmiSSaL suite asserts the contract documented in useDialogManager.ts: Escape closes the top-most dialog and click-outside closes the overlay, for the work-item details / create-work-item / create-graph modals and the graph- selector, user-menu, and settings visual-quality dropdowns. No source changes; all overlays already honor the contract. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🧪 Comprehensive Test Suite
Full-stack smoke gate runs in the CI workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A second missing test category: overlay dismissal. The dialog manager (
hooks/useDialogManager.ts) documents a friction contract — "Escape always closes the top-most dialog; click-outside closes; users never hunt for X buttons" — that had no e2e coverage. This@dismissalsuite keeps every overlay honest about closing.Coverage
No source changes — every overlay already honors the contract; this locks it in so a regression (a dropdown/modal that won't dismiss — exactly the friction users notice) fails CI.
Verification
tests/e2e/overlay-dismissal.spec.ts— 7/7 pass on local dev.🤖 Generated with Claude Code