Repository navigation
Improve node graph navigation performance - #4824
Merged
Merged
Conversation
Member
Author
|
@timon-schelling can you test this improves the performance? you don't need to do a full code review |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
timon-schelling
approved these changes
Oct 26, 2026
timon-schelling
left a comment
timon-schelling
left a comment
Member
There was a problem hiding this comment.
Definitely an improvement for editing, but panning in big graphs is still slow (likely just browser performance degrading with a lot of elements).
Keavon
added a commit
that referenced
this pull request
Oct 26, 2026
* Inspect nodes without recompiling the graph (#4803) * Edit the inspected node's context in the Data panel (#4804) * Render thumbnails with Vello (#4805) * Require attribute names to be compile time constants (#4822) * Desktop: Recover from UI crashes and apply preferences without restarting (#4827) * Desktop: Recover from UI crashes and apply preferences without restarting * Show open dialog again after a UI restart * Improve node graph navigation performance (#4824) * Re-render only the node graph wires whose paths changed * Keep nodes already in view rendered when the node graph's visible nodes change * Cleanup const checking in the compiler (#4825) * Cleanup const checking in the compiler * Reject constant data fields and update README node snippet * Group all boolean node attributes into NodeFlags * Fix numerous bugs with the Path and Pen tools (#4830) * Fix the Path tool ignoring the first click on a segment after any drag * Make Enter and Esc during a Pen drag finish or cancel only that segment * Stop Ctrl+Delete and Shift+Delete acting on a lone selected handle's anchor * Keep the opposite handle's length when nudging a handle with the Path tool * Fix Undo doing nothing after a plain click on a point with the Path tool * Make the Path tool snap and lock a handle's angle on any of several selected paths * Fix a Path tool drag just beside a segment moving the selected points * Extend a path inside a selected group with the Pen, keeping it there * Make Enter and Esc both take back the Pen tool's lone first anchor * Fix the Pen tool drawing into another selected path after starting on a segment * Make Space move the Pen tool's anchor as soon as it's pressed mid-drag * Fix Shift-clicking a selected segment leaving its anchors selected * Fix smoothing an anchor on top of its neighbor aiming its handle the wrong way * Hide the Path tool's Swap Dragged Handle hint for a handle without a partner * Fix Tab during a Path or Pen handle drag also switching to the Select tool * Stop the Path tool editing the points of locked layers * Scale the handles of exactly two selected anchors along with them * Pull out a symmetric pair of handles when Alt-dragging a sharp anchor * Make a Path tool lasso that closes on its start select what it encloses * Delete the selected layers with the Path tool when no points are selected * Stack: Path and Pen tools (bugfix-stack-path-and-pen) * Keep the Fill and Gradient tools from editing locked layers * Make the Eyedropper tool sample the canvas color around artboards in Normal mode * Center the Eyedropper tool's sample on the pointer on HiDPI displays * Finish an Eyedropper sample on any release, and skip it outside the viewport * Fix the Eyedropper tool picking no color in SVG Preview mode on the web * Stop the Fill tool previewing a fill over images it can't fill * Stop the Fill tool's color picker offering None, which it can't fill with * Fix the Gradient tool's hover missing evenly spaced stops on cyclic gradients * Deselect the Gradient tool's stop on Esc and on presses that land on nothing * Start new gradients from the Gradient tool's customized stops * Keep the Pen, Spline, and Freehand tools' Fill and Stroke ticks when nothing is selected * Fill new shapes with the gradient shown in the drawing tools' Fill swatch * Fix new shapes losing their stroke or keeping a deselected layer's dashes * Make the Fill and Gradient tools paint a Boolean Operation's result * Keep stroke weights when resizing Pen, Freehand, and Spline layers * Correct the Gradient tool's comment on its empty-canvas fallback * Stack: Fill, Gradient, tool colors, and Eyedropper (bugfix-stack-paint-and-color) --------- Co-authored-by: Dennis Kobert <dennis@kobert.dev> Co-authored-by: Timon <me@timon.zip>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.