fix(frontend): register INTERCOM_ID as a runtime env key - #256
Closed
xxl007 wants to merge 1 commit into
Closed
Conversation
config.ts reads INTERCOM_ID through getRuntimeValue, but the key is missing from frontend/.env.example (the runtime-env-cra key registry) and from the docker-compose frontend environment, so self-hosted deployments cannot actually set it: runtime-env.js never emits the key. Register it in both places.
👷 Deploy request for atlasjs-home pending review.Visit the deploys page to approve it
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
config.ts reads INTERCOM_ID through getRuntimeValue, but the key is missing from frontend/.env.example (the runtime-env-cra key registry) and from the docker-compose frontend environment, so self-hosted deployments cannot actually set it: runtime-env.js never emits the key. Register it in both places.