Skip to content

docs: clarify W1 post-merge verification evidence - #86

Merged
sethoshi18 merged 1 commit into
mainfrom
docs/w1-review-precision-fixes
Nov 6, 2026
Merged

sethoshi18 merged 1 commit into
mainfrom
docs/w1-review-precision-fixes

Conversation

@sethoshi18

Copy link
Copy Markdown
Collaborator

Summary

Documentation-only PR resolving the two low-severity observations from the independent review of PR #85 (W1.1 post-merge verification evidence). No code, tests, workflows, harnesses, manifests, or approved hashes are touched.

Observation 1 — §4 logs-tail wording

The acceptance record previously stated that every adversarial case carries "the rejected transaction id + slot + logs tail", implying a populated logs tail for all 14 cases. The verbatim JSON artifact shows:

  • all 14 cases carry the rejected transaction id, the slot, zero_movement.proved = true and the per-check zero-movement fields;
  • 13 of the 14 cases carry a populated logs_tail;
  • A2's logs_tail is empty — valid evidence, because the A2 rejection occurs at instruction 0 (the signature-verification precompile errors before the program is ever invoked, so no program logs are emitted).

§4 now states this precisely, records that logs tails are captured when available, and explicitly notes that an empty logs tail does not indicate missing transaction evidence or a failed adversarial test.

Observation 2 — §3 toolchain citation attribution

§3 previously listed Anchor CLI 1.2.2 and embedded SBF rustc 1.89.0-dev under the pins "from scripts/devnet/provenance.manifest.json". The manifest pins Solana CLI 3.0.10, SBPF v0, platform-tools v1.54 (archive sha256 fcc41631…) and the approved Scanner/Vault ELF digests — it does not pin the Anchor CLI version or the embedded rustc version as standalone fields. §3 now attributes each value to its direct evidence source:

  • Anchor CLI 1.2.2 — the scripts/check-toolchain.sh output recorded in §3.1;
  • embedded SBF rustc 1.89.0-dev — the toolchain information embedded in the SHA-256-pinned platform-tools v1.54 archive (inspection recorded in §3.2).

Reported versions are unchanged; no claim is made about manifest fields the manifest does not contain.

Scope verification

  • git diff vs main touches exactly one file: docs/w1-post-merge/W1_POST_MERGE_VERIFICATION.md (16 insertions, 5 deletions).
  • run-report-2026-11-06T06-49-37-889Z.json and run-report-2026-11-06T06-49-37-889Z.summary.md remain byte-identical to main (git blob hashes 7c155953, 1a3a6e3b — unchanged).
  • No W1 result, classification, or boundary statement was modified.

Documentation checks

  • scripts/doc-links-lint.sh — 132 relative link targets checked, all resolve (exit 0).
  • scripts/terminology-lint.sh — no forbidden vocabulary detected (exit 0).
  • prettier --check . (3.9.10, repo config) — all files pass, including the edited document (exit 0).

Two low-severity documentation observations from the independent PR #85
review; documentation-only, no evidence artifact touched.

1. Section 4 (zero-movement evidence): the acceptance record implied every
   adversarial case carries a logs tail alongside the transaction id and
   slot. In the verbatim JSON artifact all 14 cases carry the rejected
   transaction id + slot + zero-movement checks, 13 carry a populated
   logs_tail, and A2's logs_tail is empty — valid evidence, because the A2
   rejection occurs at instruction 0 before any program log is emitted.
   The wording now states exactly that and does not imply missing evidence.

2. Section 3 (toolchain attribution): Anchor CLI 1.2.2 and embedded SBF
   rustc 1.89.0-dev were listed under the provenance-manifest pins. The
   manifest pins Solana CLI 3.0.10, SBPF v0, platform-tools v1.54 (archive
   sha256) and the approved ELF digests — it does not pin the Anchor CLI
   version or the embedded rustc version as standalone fields. Each value
   is now attributed to its direct evidence source (check-toolchain.sh
   output; embedded toolchain information of the SHA-256-pinned
   platform-tools v1.54 archive). Reported versions unchanged.

Verbatim artifacts run-report-2026-11-06T06-49-37-889Z.json and
.summary.md remain byte-identical (git blob hashes 7c15595, 1a3a6e3).

@graveyieldprotocol graveyieldprotocol left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent review completed — APPROVE. This approval is pinned to head 1a20bfe0a0a6d7d398b7d83d04ddf9fe1f973129.

Verified independently against the live GitHub state and repository contents:

  • Scope: exactly one modified file, docs/w1-post-merge/W1_POST_MERGE_VERIFICATION.md, +16/−5, single commit; the merge-base diff contains nothing else.
  • Observation 1 (adversarial log-tail wording): checked against run-report-2026-11-06T06-49-37-889Z.json. All 14 adversarial cases carry a transaction id, a slot, zero_movement.proved = true and per-check zero-movement evidence; 13 of 14 cases have a populated logs_tail; A2's is empty, with the recorded failure InstructionError[0, Custom:2] (precompile family) — consistent with the revised instruction-0 / signature-verification-precompile explanation. The new wording does not imply missing transaction evidence and does not weaken the significance of the empty log tail.
  • Observation 2 (toolchain attribution): scripts/devnet/provenance.manifest.json contains Solana CLI 3.0.10, SBPF v0, platform-tools v1.54 (archive sha256 fcc41631…) and the approved Scanner/Vault ELF digests, and carries no Anchor CLI or rustc fields. The revised §3 attributes Anchor CLI 1.2.2 to the scripts/check-toolchain.sh output recorded in §3.1, and the embedded SBF rustc 1.89.0-dev to the sha256-pinned platform-tools v1.54 archive inspection recorded in §3.2. The prior manifest over-claim is corrected.
  • Historical evidence integrity: the W1.1 JSON report and Markdown summary are byte-identical to main (git blob equality); no lifecycle/adversarial result, classification, approved hash, or security-boundary statement was altered; nothing was regenerated or replaced.
  • CI at this exact head: 13 checks passed, 0 failed, 0 pending. build + fetch + run 7 fork suites was skipped by its fail-closed change-detection gate (docs-only diff); the skip is visible by design and is not counted as a pass. CodeQL completed successfully. scripts/doc-links-lint.sh and scripts/terminology-lint.sh were re-run locally at this commit: both exit 0. Prettier is out of scope for *.md per .prettierignore.
  • Non-blocking, out-of-scope observation: .github/workflows/fork-harness.yml line 51 reads branches: ain] (apparently a corrupted branches: [main]). Pre-existing on main, empirically inert (pull_request-triggered fork-harness runs fire systematically), and untouched by this PR. Recommend a separate one-line follow-up PR.

Recommendation basis: exact scope, both corrections evidence-supported, historical evidence untouched, CI green with the documented gate-driven skip. PR remains open for maintainer disposition.

@sethoshi18
sethoshi18 merged commit 3066738 into main Nov 6, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants