Refactor/dao split cleanup

[marsof02]

Thank you for opening a Pull Request!

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

• Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
• Ensure the tests are added/updated (if necessary)
• Ensure the linter passes (./codeAnalysis to automatically apply formatting/linting)
• Appropriate docs were updated (if necessary)

Summary

Collapsing the last 4 PRs for #1235 - Stacks on #1318
Below are the original descriptions of the individual PRs:

PR 3 of 6 for #1235 — migrates session and current-tree callers off TreeTrackerDAO:

Stacks on #1 (branch chore/treetracker-dao-split-repos) and #1303.
Merge after previous PRs, or review against that branch only.

TreeTrackerDAO is still used elsewhere; removed in a later PR.

PR 4 of 6 for #1235 — migrates planter (legacy) and tree capture callers off TreeTrackerDAO:

Stacks on #2 (branch chore/split-treetracker-dao-session-tree), #1, and #1303.
Merge after previous PRs, or review against that branch only.

TreeTrackerDAO is still used elsewhere; removed in a later PR.

PR 5 of 6 for #1235 — migrates location + sync/dashboard off TreeTrackerDAO.

Stacks on #3 (branch chore/split-treetracker-dao-planter-treecapture), #2, #1, and #1303.
Merge after previous PRs, or review against that branch only.

PR 6 of 6 for #1235 — removes TreeTrackerDAO and splits tests.

Stacks on #4 (branch refactor/split-treetracker-dao-location-sync), #3, #2, #1, and #1303.
Merge after previous PRs, or review against that branch only.

Out of scope

• Hardening DAO integration test assertions (follow-up)

The split preserves existing TreeTrackerDaoTest behavior. Several update/delete tests use weak assertions that pass without re-querying the DB (e.g. comparing against Unit, or assertNotEquals on unrelated types). Insert tests that use shared FakeFileGenerator fixtures may pass because Room writes generated ids back into those objects.

Not introduced by this PR — carried over from the monolith test. Happy to tighten in a follow-up issue/PR.

📸 Proof of change (REQUIRED)

Every PR must include a screen recording / video showing the change working.
UI changes must also include before/after screenshots.
Just drag-and-drop the files into the boxes below — GitHub will upload them.
PRs without the required media will be flagged automatically and cannot be merged.

🎥 Screen recording / video (always required)

1235_CI.mp4

🖼️ Screenshots (required for any UI change)

Before	After

• This change has no user-visible / UI effect (refactor, docs, CI, etc.), so screenshots are not applicable.
  • A maintainer may also apply the non-ui label. A video is still required even for non-UI changes.

Fixes #1235 🦕