fix getting address of cluster 0 #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the changes in 530b663 to suuport larger disk the math to covert a to an address underflows then it cast to a wider int without sign extention leaving a bit set in the middle of the number. This change moves the subtraction to happen after the other additions and widening thus prevting any underflow issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the changes in 530b663 to suuport larger disk the math to covert a
to an address underflows then it cast to a wider int without sign extention
leaving a bit set in the middle of the number.
This change moves the subtraction to happen after the other additions
and widening thus prevting any underflow issues.
fixes #30