-
Notifications
You must be signed in to change notification settings - Fork 432
feat: add building option to build images base on distroless image #7240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for building GreptimeDB Docker images based on distroless images for enhanced security and smaller image size, while also fixing Docker best practice warnings in existing Dockerfiles.
- Adds two new distroless Dockerfile variants (ci and buildx)
- Standardizes ENV variable syntax across all Dockerfiles (removes spaces around
=) - Capitalizes
ASkeyword in multi-stage builds to follow Docker best practices
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| docker/ci/distroless/Dockerfile | New distroless-based image for CI builds |
| docker/buildx/distroless/Dockerfile | New distroless-based image with build-from-source support |
| docker/ci/ubuntu/Dockerfile | Fixed ENV syntax warning |
| docker/ci/centos/Dockerfile | Fixed ENV syntax warning |
| docker/buildx/ubuntu/Dockerfile | Fixed ENV syntax and capitalized AS keyword |
| docker/buildx/centos/Dockerfile | Fixed ENV syntax and capitalized AS keyword |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
09ac5a2 to
28176f1
Compare
28176f1 to
b5cbfb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm can you also add info to the docs repo?
like https://github.com/GreptimeTeam/docs/blob/9f492d9c42a47bb519cc70b5a2b1a4f3367271a7/docs/getting-started/installation/greptimedb-standalone.md?plain=1#L71
|
@WaterWhisperer Just one more concern with the duplicates in ubuntu version and distroless version. Do you think we should switch completely from ubuntu to distroless? Is there any impact? @daviderli614 what's your ideas about this? |
I'd recommend keeping both as options rather than switching completely. Ubuntu is easier debugging and Distroless is smaller, more secure. |
Okay, I'd like to work on #2217 when this PR doesn't need any changes |
Signed-off-by: WaterWhisperer <[email protected]>
b5cbfb8 to
bf69c85
Compare
…reptimeTeam#7240) Signed-off-by: WaterWhisperer <[email protected]>
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#2115
What's changed and what's your intention?
support building option to build images base on distroless image and fix some warning in existing Dockerfile to remove noise
PR Checklist
Please convert it to a draft if some of the following conditions are not met.