Draft
Conversation
There was a problem hiding this comment.
Pull request overview
Ports the C++/Python bindings from pybind11 to nanobind, updating build configuration and exposing nanobind-backed array/ndarray interfaces (incl. array API / DLPack-related hooks).
Changes:
- Switch CMake build from
pybind11_add_moduletonanobind_add_moduleand update dependency discovery. - Replace pybind11 binding code with nanobind equivalents across all exposed Atlas types.
- Introduce nanobind ndarray-based views for
Field(host/device access + NumPy/CuPy/DLPack entry points).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
src/atlas4py/CMakeLists.txt |
Updates build to find/link nanobind and build the extension with nanobind_add_module. |
src/atlas4py/_atlas4py.cpp |
Rewrites the binding layer for nanobind and adds ndarray/array interop for fields. |
pyproject.toml |
Switches build-system requirement from pybind11 to nanobind. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports the pybind11 implementation to use nanobind instead.
Unit tests had already been improved with previous PR #32, to catch errors in porting, and are untouched here.
Especially noteworthy here are the new array-view interfaces which nanobind brings more naturally, with support for DLPACK etc.