Fix wrong python version selection in some daily CI tasks#2576
Merged
egparedes merged 13 commits intoGridTools:mainfrom Apr 17, 2026
Merged
Fix wrong python version selection in some daily CI tasks#2576egparedes merged 13 commits intoGridTools:mainfrom
egparedes merged 13 commits intoGridTools:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes daily CI running unintended extra tests by correcting nox session selection and aligning Python version handling, plus adds CI debugging guidance.
Changes:
- Update
nox/uvPython version selection behavior and constraints innoxfile.py. - Fix daily CI workflow invocation to use
nox -k(instead of-toverriding-s) and pass the target Python via-p. - Add CI-only debugging comments/options for collecting tests without running them.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| noxfile.py | Updates shebang Python version, sets UV_VENV_CLEAR, and adjusts the manual Python version constraint used when creating session envs. |
| .github/workflows/daily-ci.yml | Adjusts the CI run commands to avoid -t overriding -s, adds debug output, and documents a collect-only knob. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
romanc
approved these changes
Apr 17, 2026
Contributor
romanc
left a comment
romanc
left a comment
There was a problem hiding this comment.
To be completely honest, this is all a bit voodo to me, but in general terms I think this looks good.
Happy to hear that we don't have 80 workflosws running anymore nightly 🎉
edopao
approved these changes
Apr 17, 2026
Contributor
edopao
left a comment
edopao
left a comment
There was a problem hiding this comment.
Thanks for this fix! LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug in the way
noxwas called to run some specific sessions which made every CI matrix entry run more tests than needed:-t(tag filter) and-s(session filter) options do not interact together as an intersection, but-tcompletely replaces-s.Additionally, fix some other minor issues and add comments on how to debug CI issues for this workflow without running all tests.