Skip to content

refactor[cartesian]: Avoid dummy DebugInfo in favor of configuration#2581

Merged
FlorianDeconinck merged 1 commit intoGridTools:mainfrom
romanc:romanc/dace-remove-fake-line-info
Apr 21, 2026
Merged

refactor[cartesian]: Avoid dummy DebugInfo in favor of configuration#2581
FlorianDeconinck merged 1 commit intoGridTools:mainfrom
romanc:romanc/dace-remove-fake-line-info

Conversation

@romanc
Copy link
Copy Markdown
Contributor

@romanc romanc commented Apr 21, 2026

Description

DaCe now comes with a configuration option whether or not to inspect the python stack in case debug information (e.g. line number) is missing. We previously used a fake DebugInfo object to prevent the call to inspect(). With the new configuration option, we can remove those fake objects again and just configure the desired behavior.

A word of caution: until spcl/dace#2344 or something similar is merged, DaCe will output a ton of deprecation warnings caused by the addition of the new config option.

Requirements

  • All fixes and/or new features come with corresponding tests.
    N/A
  • Important design decisions have been documented in the appropriate ADR inside the docs/development/ADRs/ folder.
    N/A

DaCe now comes with a configuration option whether or not to inspect the
python stack in case debug information (e.g. line number) is missing. We
previously used a fake `DebugInfo` object to prevent the call to
`inspect()`. With the new configuration option, we can remove those fake
objects again and just configure the desired behavior.
@romanc romanc marked this pull request as ready for review April 21, 2026 16:16
@romanc romanc requested a review from FlorianDeconinck April 21, 2026 16:16
Copy link
Copy Markdown
Contributor

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean up 🧹

@FlorianDeconinck FlorianDeconinck merged commit c1b9c80 into GridTools:main Apr 21, 2026
32 checks passed
@romanc romanc deleted the romanc/dace-remove-fake-line-info branch April 21, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants