Upgrade recompose to ^0.25.1 #839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first version of recompose compatible with React 16 (acdlite/recompose#530 (comment))
Contributor
Author
|
CI is failing in |
Open
Contributor
Author
|
After merging in #840, specs pass |
Contributor
|
Hi! Is there any chance that this could be merged? It looks like specs pass now and it seems like there should not be any significant changes: https://github.com/acdlite/recompose/releases?after=v0.25.1 I think technically Griddle can be used on React 16 already, but you will get warnings during npm/yarn install about incorrect peer dependency versions. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Griddle major version
v1
Changes proposed in this pull request
Upgrade recompose to ^0.25.1
Why these changes are made
This is the first version of recompose "officially" compatible with React 16.
(acdlite/recompose#530 (comment))
Griddle react seems to work fine in React 16 without this change.
#823 would achieve the same result, but seems to have failing CI tests.
This is minimal change required to resolve warning
"griddle-react > [email protected]" has incorrect peer dependencyfrom npm/yarn.Are there tests?
No additional tests.