♻️ Guard against KeyError escape from validate_settings_rules#289
Merged
Conversation
Gudsfile
changed the base branch from
main
to
refactor/decouple-current-tag-sync
Gudsfile
force-pushed
the
169-cli-boundaries-a
branch
from
7dddbff to
5295dfd
Compare
Gudsfile
changed the title
Gudsfile
changed the title
validate_settings_rules could theoretically raise a KeyError if a future rule bypasses the get_rules_supported_by_settings pre-filter. The catch is added defensively so any such escape is wrapped as an actionable InvalidSettingsError rather than a generic crash.
The "requires the optional" phrase only appears in MissingOptionalDependencyError.install_hint, not in ModuleNotFoundError messages. The string check in _build_server_app could never match, so it was dead code that added noise without effect.
Gudsfile
force-pushed
the
169-cli-boundaries-a
branch
from
5295dfd to
74aced7
Compare
Gudsfile
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #169
validate_settings_rulescould theoretically raise aKeyErrorif a future rule bypasses theget_rules_supported_by_settingspre-filter. The catch is added defensively so any such escape is wrapped as an actionableInvalidSettingsErrorrather than a generic crash.