♻️ Surface settings errors with typed codes and paths#290
Merged
Conversation
5295dfd to
74aced7
Compare
961916a to
911cd75
Compare
Add ErrorCode (StrEnum) and optional path to InvalidSettingsError so callers can inspect failure kind and affected path without message parsing. Update all raise sites across settings, migration, and adapter layers.
Replace message.startswith() sub-classification in _render_invalid_settings_error with a match on err.code, and path extraction with err.path.
Replace text parsing in _extract_compact_detail with ValidationError.errors() when the error's __cause__ is a ValidationError. Non-validation failures (ValueError, patch format errors) retain the text-fallback path.
911cd75 to
1969ede
Compare
Owner
Author
|
extra
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #169
Test plan
jukebox-admin settings set <unsupported.path> valueand verify the error message names the path.--verboseand verify full details are still visible.