Ensure conda packaging finds xsimd and eigen#943
Open
psavery wants to merge 2 commits into
Open
Conversation
Before, it appeared to be performing the fallback install of xsimd and eigen via the `install_build_dependencies.py` script. Now, it should be using the packages from conda as it should, and thus the build packaging should update the versions automatically. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
To the latest that are available on conda-forge (so we can match the packaging builds). Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #943 +/- ##
=======================================
Coverage 72.62% 72.62%
=======================================
Files 142 142
Lines 21944 21944
=======================================
Hits 15936 15936
Misses 6008 6008 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Before, it appeared to be performing the fallback install of xsimd and eigen via the
install_build_dependencies.pyscript.Now, it should be using the packages from conda as it should, and thus the build packaging should update the versions automatically.
Affected Workflows
All, via dependency updates
Documentation Changes
None