Add pink-beam heating peak shape#944
Open
psavery wants to merge 24 commits into
Open
Conversation
This should make the ruff formatting very similar to `black` Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
This adds new blocks and corrects some string names so that the new pink beam heating code will be used everywhere that it should. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
This amplitude multiplication matches what is happening in the other pick methods. The invalid tau values were just being produced by lmfit while it was varying values. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
They were inadvertently being fixed to each other's values Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
This fixes a similar issue as the last commit, but for the original DCS pink beam code. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
…ew numba functions
split into pink_beam_heating (sigma) and pink_beam_exponential (tau), wire exponential as a full peak shape, fix conversion bugs, revert dcs changes, drop dead code, update tests Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #944 +/- ##
==========================================
+ Coverage 72.65% 73.07% +0.41%
==========================================
Files 143 143
Lines 22083 22538 +455
==========================================
+ Hits 16045 16469 +424
- Misses 6038 6069 +31 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
saransh13
approved these changes
Jun 10, 2026
saransh13
left a comment
saransh13
left a comment
Member
There was a problem hiding this comment.
LGTM. can merge after windows condo_package issue is resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds a sigma-based heating pink-beam peak shape (
pvheating, peakshape3)for heating experiments, and splits the existing tau-based math into its own
exponential shape (
pvexponential, peakshape4). Both are wired throughfitpeak,spectrum, and WPPF, with tests for each. Also adds a ruff config.Affected Workflows
Core: new peak shapes added, and
pink_beam_dcsissues fixed in a few placesPowder: same but for WPPF
Documentation Changes
None