feat: embed local Markdown image references as data URIs during indexing#525
Open
xiongjnu wants to merge 1 commit into
Open
feat: embed local Markdown image references as data URIs during indexing#525xiongjnu wants to merge 1 commit into
xiongjnu wants to merge 1 commit into
Conversation
When a Markdown document references local images (e.g. ), resolve them relative to the markdown file and inline as base64 data URIs before passing the document to the embedding pipeline. This ensures images packaged in a zip upload survive the extraction and indexing step without broken links. External URLs and data URIs are left untouched. Images exceeding 500 KB are skipped to keep the index size reasonable. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Markdown document references local images (e.g.
), resolve them relative to the markdown file and inline as base64 data URIs before passing the document to the embedding pipeline. This ensures images packaged in a zip upload survive the extraction and indexing step without broken links.External URLs and data URIs are left untouched. Images exceeding 500 KB are skipped to keep the index size reasonable.
This is a companion to PR #522 (zip upload support) — without image inlining, markdown files extracted from a zip archive would have broken local image references.
Test plan
referencing a local image → image is inlined as data URI in the document text→ left untouched