Open
Conversation
includes: commenting out unused variables in PDAF code
in order to get Oasis-files compiled correctly
Error ``` parflow_pdaf/pfsimulator/parflow_lib/solver_richards.c:1817:16: error: unused variable ‘pfl_start’ [-Werror=unused-variable] ``` Background: In `PseudoAdvanceRichards`, there are many unused variables.
branch matching current generic ParFlow from TSMP2
Member
|
The issue seems to be the way ParFlow linker flags are manually specified: TSMP2/cmake/BuildPDAFMODEL.cmake Lines 98 to 104 in f45128a The correct linker flags for ParFlow 3rd party dependencies (e.g. CUDA, Hypre) are generated by the ParFlow CMake scripts. Unfortunately TSMP2 cannot directly access these flags since they are dynamically generated. We need to find a way to extract these linker info from ParFlow. |
This was referenced Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Started from issue #81
Opening PR for testing CI.
Related: HPSCTerrSys/pdaf#30