Skip to content

AB#74 refactor near you view #5607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
vesameskanen wants to merge 67 commits into
base: v3
Choose a base branch
from
Draft

AB#74 refactor near you view #5607

vesameskanen wants to merge 67 commits into from

Conversation

@vesameskanen
Copy link
Member

@vesameskanen vesameskanen commented Dec 23, 2025 •
edited
Loading

  • Useless duplicate state removed
  • Split to sub components
  • Function components only
  • Simplify code
  • Rename a lot
  • Refactor a lot
  • No proptype warnings on debugger

Several bugs got fixed, for example favorites near you now shows vehicles on map.

@vesameskanen
fix: location prop name for search
10a3f13
@vesameskanen
Merge branch 'v3' into AB#74
b4cc48d
@vesameskanen
fix: remove unnecessary div with nonexistent style class
5652a79
@vesameskanen
chore: rename variables
40c5a7b
@vesameskanen
chore: refactor DepartureRow
dcaab48
@vesameskanen
fix: use simple callback prop for capacity modal opening
e9f1167
@vesameskanen
chore: remove useless prop
754dc11
@vesameskanen
chore: use consistently favourite (not favorite)
2c86889
@vesameskanen
chore: rename more components
ca95d57 
It does not make sense to prefix everything with 'Stop'
@vesameskanen
fix: remove invalid param from executeAction
e35ab5e
@vesameskanen
fix: strange double expression
80003b3
@vesameskanen
fix: various update bugs
10e9de3 
Pass consistent currentTime and tab activation props to child components.
@vesameskanen
fix: NearYouFavouritesMapContainer props
4bc76ab
@vesameskanen
fix: hundreds of relay warnings caused by missing vehicle rental stat…
09aec9e 
…ion fragment
@vesameskanen
fix: favourite vehicle rental station prop name errors
2ce8c71
@vesameskanen
chore: remove fake props
15af1ea
@vesameskanen
fix: remove useless connection with 2 stores
faf7995
@vesameskanen
chore: remove unused prop
857d32d
@vesameskanen
chore: refactor StopNearYou
010b38d 
- Remove fake props
- reqeuire all props
@vesameskanen
chore: refactor VehicleRentalStationNearYou
84cc123
@vesameskanen
fix: remove unnecessary store connection from NearYouContainer
4b79ac8
@vesameskanen
fix: remove unnecessary store connections from NearYouMapContainer
946c8df
@vesameskanen
fix: favouriteIds is required prop, code will crash without it
8d6ed1f
@vesameskanen
chore: refactor
851095c
@vesameskanen
fix: wrong prop type for FavouritesMapContainer
a81847d
@vesameskanen
fix: pass correct favouriteIds set prop to NearYouContainer
2d2c101
@vesameskanen
chore: refactor and rename
ddafa1b
@vesameskanen
fix: correct stopsNearYou prop type
9e58c51
@vesameskanen
feat: refactor NearYouContainer thoroughly
2b66e85 
- Convert to function component
- Rename and simplify
- Remove useless state, use refs not state
- Simple aria messages
@vesameskanen
chore: rename
66c0ccc
@vesameskanen
fix: update renamed props in map component, too
f73ff90
@vesameskanen
Merge branch 'v3' into AB#74-patch1
96de343
@vesameskanen
fix: buggy LocationMarker key, remove unnecessary wrapper func
94aa516
@vesameskanen
chore: refactor route and vehicle drawing on near you map
6ec7a3c
@vesameskanen
chore: refactor near you map more
59919b6
@vesameskanen
fix: remove unnecessary stop list conversion to another data type, re…
9cf8100 
…factor more
@vesameskanen
fix: show vehicles on favourites near you map
35ad0ee 
This has apparently been always broken
@vesameskanen
fix: remove unused query fields and arguments from fav map container
5e85d29
@vesameskanen
fix: remove triple code in favourite mapping
0d72539
@vesameskanen
fix: remove unncessary near youy map container query fields and argum…
1b90286 
…ents
@vesameskanen
fix: remove strange relay.loadMore from near you map
453d70d
@vesameskanen
chore: simplify nearyou code more
d893c85
@vesameskanen
feat: move city bike info to own component
b85aa68
@vesameskanen
fix: don't render 0
4c32d91
@vesameskanen
Merge branch 'v3' into AB#74-patch1
7fe3728
@vesameskanen
fix: restore bike season
cc90356
@vesameskanen
fix: use standard severe alert color for low city bike capacity
21fe5e1 
It was previously subway orange
@vesameskanen
fix: use color variable instead of hard coded value
b6f672c
@vesameskanen vesameskanen changed the title AB#74 refactore near you view thoroughly AB#74 refactor near you view Dec 29, 2025
@vesameskanen vesameskanen marked this pull request as draft January 2, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vesameskanen