Skip to content

fix: resolve service.impl test context failures and update Java 26-ea to 26 #8555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pethers merged 5 commits into from
Apr 13, 2026
Merged

fix: resolve service.impl test context failures and update Java 26-ea to 26 #8555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6583f02
fix: resolve service.impl test failures - add ESV context, exclude EC…
Copilot Apr 12, 2026
3dd5972
fix: restore ECJ compiler, set Java 21 language level for Drools, cle…
Copilot Apr 12, 2026
a09bba6
chore: remove accidentally committed binary and data files
Copilot Apr 12, 2026
d54082f
Update service.impl/src/test/java/com/hack23/cia/service/impl/Abstrac…
pethers Apr 13, 2026
2ffc5c7
Update service.impl/src/main/resources/META-INF/kmodule.xml
pethers Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/skills/github-actions-workflows/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Create and maintain secure, efficient CI/CD pipelines using GitHub Actions for t

| Component | Version | Notes |
|-----------|---------|-------|
| **Java JDK** | 26-ea (Temurin) | Source level 21 |
| **Java JDK** | 26 (Temurin) | Source level 21 |
| **Maven** | 3.9.14 | Multi-module reactor build |
| **PostgreSQL** | 18 | Extensions: pgaudit, pgcrypto, pg_stat_statements |
| **Node.js** | 24 | MCP servers, Playwright |
Expand Down Expand Up @@ -54,7 +54,7 @@ jobs:
- name: Set up JDK 26
uses: actions/setup-java@c5195efecf7bdfc987ee8bae7a71cb8b11521c00 # v4.7.1
with:
java-version: '26-ea'
java-version: '26'
distribution: 'temurin'
cache: 'maven'

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codeql-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ jobs:
uses: actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654 # v5.2.0
with:
distribution: "temurin"
java-version: "26-ea"
java-version: "26"
# Disable built-in cache - we use optimized manual caching below
cache: ""

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/copilot-setup-steps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ jobs:
uses: actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654 # v5.2.0
with:
distribution: "temurin"
java-version: "26-ea"
java-version: "26"
# Disable built-in cache - we use optimized manual caching below
cache: ""

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/javadoc-generation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ jobs:
uses: actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654 # v5.2.0
with:
distribution: 'temurin'
java-version: '26-ea'
java-version: '26'
java-package: 'jdk'
check-latest: true
# Disable built-in cache - we use optimized manual caching below
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ jobs:
uses: actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654 # v5.2.0
with:
distribution: 'temurin'
java-version: '26-ea'
java-version: '26'
java-package: 'jdk' # Explicitly specify JDK package
check-latest: true # Always get latest patch version
# Disable built-in cache - we use optimized manual caching below
Expand Down
15 changes: 9 additions & 6 deletions service.impl/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,11 +104,6 @@
<artifactId>protobuf-java</artifactId>
<version>4.34.1</version>
</dependency>
<dependency>
<groupId>org.eclipse.jdt</groupId>
<artifactId>ecj</artifactId>
<version>3.45.0</version>
</dependency>
<dependency>
<groupId>org.quartz-scheduler</groupId>
<artifactId>quartz</artifactId>
Expand Down Expand Up @@ -377,7 +372,15 @@
</dependency>
</dependencies>
<build>
<plugins></plugins>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<argLine>${surefireArgLine} ${testAdditionalRuntimeArgLine} -Ddrools.dialect.java.compiler.lnglevel=21</argLine>
</configuration>
</plugin>
</plugins>
<extensions></extensions>
</build>
</project>
7 changes: 3 additions & 4 deletions service.impl/src/main/java/com/hack23/cia/service/impl/rules/RulesConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ public KieContainer kieContainer() {
final KieServices kieServices = KieServices.Factory.get();
final KieContainer kContainer = kieServices.getKieClasspathContainer();

LOGGER.info("Using classloader {}, parent {}",kContainer.getClassLoader(),kContainer.getClassLoader().getParent());
LOGGER.info("Using classloader {}, parent {}", kContainer.getClassLoader(),
kContainer.getClassLoader().getParent());

final Results verifyResults = kContainer.verify();
for (final Message m : verifyResults.getMessages()) {
Expand All @@ -58,14 +59,12 @@ public KieContainer kieContainer() {

final KieBase kieBase = kContainer.getKieBase();


for (final KiePackage kp : kieBase.getKiePackages()) {
for (final Rule rule : kp.getRules()) {
LOGGER.info("Loadded Rule: {} {}", kp, rule.getName());
LOGGER.info("Loaded Rule: {} {}", kp, rule.getName());
}
}


return kContainer;
}
}
6 changes: 3 additions & 3 deletions service.impl/src/main/resources/META-INF/kmodule.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<kmodule xmlns="http://www.drools.org/xsd/kmodule">
<kbase name="KBase1" default="true" packages="com.hack23.cia.service.impl.rules.party, com.hack23.cia.service.impl.rules.politician, com.hack23.cia.service.impl.rules.application">
<ksession name="KieSession" default="true"/>
</kbase>
<kbase name="KBase1" default="true" packages="com.hack23.cia.service.impl.rules.party, com.hack23.cia.service.impl.rules.politician, com.hack23.cia.service.impl.rules.application, com.hack23.cia.service.impl.rules.committee, com.hack23.cia.service.impl.rules.ministry">
<ksession name="KieSession" default="true"/>
</kbase>
</kmodule>
3 changes: 2 additions & 1 deletion ...l/src/test/java/com/hack23/cia/service/impl/AbstractServiceFunctionalIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@
"classpath:META-INF/cia-service-external-riksdagen.xml",
"classpath:META-INF/cia-service-external-worldbank.xml",
"classpath:META-INF/cia-service-external-val.xml",
"classpath:/META-INF/cia-test-context.xml" })
"classpath:META-INF/cia-service-external-esv.xml",
"classpath:/META-INF/cia-test-context.xml" })
public abstract class AbstractServiceFunctionalIntegrationTest extends AbstractFunctionalIntegrationTest {

/** The Constant EXPECT_A_RESULT. */
Expand Down
Loading