Convert coverage file to read_count dict - #270
Open
ThijsMaas wants to merge 2 commits into
Open
Conversation
StefanLelieveld
approved these changes
Aug 2, 2024
StefanLelieveld
left a comment
StefanLelieveld
left a comment
Collaborator
There was a problem hiding this comment.
Lovely, thanks for acting so fast!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to calculate the number of reads that are going to be generated when a coverage_file is used because it depends on the coverage and genome sizes. The n_reads param needs to be accurate because it is used to generate the multiprocessing chunks. This fixes that by converting the coverage_file output to a readcount_dict.