Linting/Updates - #137
Open
brettz9 wants to merge 2 commits into
Open
Linting/Updates#137brettz9 wants to merge 2 commits into
brettz9 wants to merge 2 commits into
Conversation
- Linting: Lint `/examples` files also (using `overrides` to allow `console` therein) - Refactoring: Switch to ES6 in examples and docs - npm: Update airbnb to version advertised as compatible with exiting eslint version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/examplesfiles also (usingoverridesto allowconsoletherein)I'd actually like to update ESLint to the latest versions, but if we get tests/coverage in place, using the latest versions, e.g., of mocha/nyc, will likely require Node 10+, causing a breaking change if ensuring all claimed supported versions are tested, and wasn't sure you'd be open to that, so starting off small. FWIW, many projects are dropping support for End-of-lifed versions (i.e., pre Node 10).
(If this project is no longer being maintained, I'd be grateful for a heads up so I can, as feasible, start a fork or something.)
Thanks much! Looks like a very handy project!