Clarify tool details shortcut hints#3551
Merged
Hmbown merged 3 commits intoJun 24, 2026
Merged
Conversation
Replace ambiguous Alt+V/v helper copy with action-oriented details pager hints across live tool cards, task rows, footers, and context inspector text. Document Alt-V/Option-V in KEYBINDINGS and remove the stale bare-v help catalog entry now that plain v is only used for other contexts such as approval params and vim/visual input. Refs Hmbown#3194. Validation: cargo fmt; cargo test -p codewhale-tui --bin codewhale-tui --locked keybindings; cargo test --workspace --locked.
The full workspace gate can run this test after config-loading tests that modify process env. Give the flash alias test its own locked temp environment before constructing Config so it stays hermetic. Validation: cargo fmt; cargo test -p codewhale-tui --bin codewhale-tui --locked nvidia_nim_provider_normalizes_deepseek_v4_flash_alias; cargo test --workspace --locked.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f392d098c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
macOS renders the production details shortcut label as Option+V, so the checklist hint test should assert the shared helper output instead of hardcoding Alt+V. CI: fixes the macOS failure in Test (macos-latest) for tui::history::tests::render_checklist_change_card_shows_only_changed_item. Windows was canceled after the macOS job failed. Validation: cargo fmt; cargo test -p codewhale-tui --bin codewhale-tui --locked render_checklist_change_card_shows_only_changed_item; cargo test --workspace --locked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Alt+V/vtool-details hints with explicit action copy such asAlt+V opens details,full output, orfull list.Option+V.vdetails-pager help entry and add a keybinding catalog regression test.Closes #3194.
Validation
cargo fmtcargo test -p codewhale-tui --bin codewhale-tui --locked keybindingscargo test -p codewhale-tui --bin codewhale-tui --locked nvidia_nim_provider_normalizes_deepseek_v4_flash_aliascargo test --workspace --lockedSelf-review
Alt+V/v,(or v), and removedKbSelectedDetailsreferences after implementation.