refactor(localization): extract hardcoded localization texts into JSON and load via rust-i18n(#3537)#3583
Open
hongqitai wants to merge 2 commits into
Open
refactor(localization): extract hardcoded localization texts into JSON and load via rust-i18n(#3537)#3583hongqitai wants to merge 2 commits into
hongqitai wants to merge 2 commits into
Conversation
Owner
|
Thanks for taking on the localization extraction. This is a broad refactor plus a new runtime dependency, so I’m going to keep it out of the late 0.8.65 release lane until the checks are fully green and we have more room to review the i18n shape. Current blocker: macOS fails in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ref #3537
Follow-up of #3549, #3559
crates/tui/src/localization.rstocrates/tui/localesrust-i18nto load localization textsrust-i18n::t!macro to replace manual string concatenationrust-i18nis a wrong way, mergecrates/tui/localesonlyTesting
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-featurescargo test --workspace --all-featuresChecklist