Skip to content

cask/artifact/moved: use mv instead of cp and rm #21014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+2 −4
Closed

cask/artifact/moved: use mv instead of cp and rm #21014

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions Library/Homebrew/cask/artifact/moved.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,15 +167,13 @@ def move_back(skip: false, force: false, adopt: false, command: nil, **options)
# This may fail and need sudo if the source has files with restricted permissions.
[!source.parent.writable?, true].uniq.each do |sudo|
result = command.run(
"/bin/cp",
args: ["-pR", target, source],
"/bin/mv",
args: [target, source.dirname],
Copy link

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from cp to mv with source.dirname as destination will not correctly restore the artifact if the target basename differs from the source basename.

For example, if a cask specifies a custom target name:

  • source in staging: OriginalName.app
  • target installed: /Applications/CustomName.app

The original code would copy to the exact source path: cp -pR /Applications/CustomName.app /path/to/staging/OriginalName.app

The new code moves to the parent directory: mv /Applications/CustomName.app /path/to/staging/ which results in /path/to/staging/CustomName.app (wrong basename).

Consider using mv target source instead of mv target source.dirname to preserve the exact source path.

Suggested change
args: [target, source.dirname],
args: [target, source],

Copilot uses AI. Check for mistakes.
must_succeed: sudo,
sudo:,
)
break if result.success?
end

delete(target, force:, command:, **options)
end

def delete(target, force: false, successor: nil, command: nil, **_)
Expand Down
Loading