dev-cmd/generate-formula-api: add dependencies to internal API. #21042
+23
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should reduce the need to download formula stubs in the vast majority of cases.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds dependency information to Homebrew's internal formula API to reduce the need to download full formula definitions (stubs) in most cases. The changes include logic to determine which uses_from_macos dependencies should be included based on the macOS version of the bottle tag being processed.
Key Changes:
- Extracts macOS version from bottle tags for version-aware dependency filtering
- Adds logic to include conditional
uses_from_macosdependencies based on the:sincebounds - Modifies the formula stub array structure to include a 5th element (dependencies)
- Adds an empty
caskskey to the formula internal API JSON structure
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rylan12
reviewed
Nov 13, 2025
Comment on lines
+102
to
+117
| if macos_version | ||
| uses_from_macos = formula["uses_from_macos"].zip(formula["uses_from_macos_bounds"]) | ||
| dependencies += uses_from_macos.filter_map do |dep, bounds| | ||
| next if bounds.blank? | ||
|
|
||
| since = bounds[:since] | ||
| next if since.blank? | ||
|
|
||
| since_macos_version = MacOSVersion.from_symbol(since) | ||
| next if since_macos_version <= macos_version | ||
|
|
||
| dep | ||
| end | ||
| else | ||
| dependencies += formula["uses_from_macos"] | ||
| end |
Member
There was a problem hiding this comment.
I reworked this slightly, so I would appreciate a second look before merging
Rylan12
approved these changes
Nov 13, 2025
Member
Rylan12
left a comment
Rylan12
left a comment
There was a problem hiding this comment.
Thanks! I made some small changes, but feel free to merge if you think things look good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should reduce the need to download formula stubs in the vast majority of cases.
CC @Rylan12 feel free to adjust, tweak, test and merge as needed!