Skip to content

fix: polish subscription limits interactions - #1

Merged
Hu9956 merged 1 commit into
Hu9956:feat/subscription-managerfrom
LceAn:feat/subscription-manager-ui-followup
Aug 25, 2026
Merged

fix: polish subscription limits interactions#1
Hu9956 merged 1 commit into
Hu9956:feat/subscription-managerfrom
LceAn:feat/subscription-manager-ui-followup

Conversation

@LceAn

@LceAn LceAn commented Aug 25, 2026

Copy link
Copy Markdown

This is a focused follow-up to xiufengsun#464, based on Hu9956:feat/subscription-manager at aa0b0b22.

What changed

  • Refine the subscription popover into a responsive, scroll-safe card with a clearer form hierarchy and two-column layout on wider windows.
  • Recompute translated provider/cycle options and date formatting when the active locale changes.
  • Replace the limits provider role="button" wrapper with a real header button and a separate content region. This prevents edit/delete/copy controls inside a provider row from accidentally toggling the row.
  • Add explicit aria-controls, animated expand affordance, selected-row surface treatment, and more integrated subscription progress/detail styling.
  • Add regression coverage for the new accessible toggle and nested setup actions.

No storage or API behavior is changed.

Validation

  • Dashboard subscription/limits tests: 35 passed
  • Dashboard lint: passed
  • Dashboard typecheck: passed
  • Dashboard production build: passed
  • validate:copy, validate:locale, validate:ui-hardcode, validate:guardrails: passed

The full root test run still contains an unrelated existing leaderboard refresh failure on this Windows checkout; the subscription-manager targeted tests pass except for the pre-existing Windows permission test that cannot simulate unreadable files.

@Hu9956

Hu9956 commented Aug 25, 2026

Copy link
Copy Markdown
Owner

Ran the full dashboard suite locally to verify this PR — great UI polish! One follow-up found: usage-limits-reset-bank.test.jsx (not touched by this diff) still locates provider groups via [role='button'], which no longer resolves now that rows use real <button> headers — 7 tests fail at 327b4cb (all pass on base aa0b0b2).

I've pushed a minimal test-only adaptation as a stacked PR into your branch: LceAn#1 (fix/reset-bank-tests-for-header-toggle). It uses the same [data-limit-group] pattern already introduced in UsageLimitsPanel.test.jsx, plus narrows one document-wide no-buttons assertion to the Reset Bank section. With it merged, #1 goes green: target file 13/13, suite 520 passed / 4 failed (those 4 fail identically on base on my machine — environmental, unrelated), lint clean.

Feel free to merge it, cherry-pick, or rework as you prefer 🙏


本地跑全量验证了这个 PR,UI 打磨很棒!一个跟进点:未被本 PR 改动的 usage-limits-reset-bank.test.jsx 仍在用 [role='button'] 定位分组,换成真按钮后查不到了——327b4cbf 上 7 个用例失败(基线全过)。

我已把仅测试的最小适配以叠加 PR 推到你分支:LceAn#1。用的就是你在 UsageLimitsPanel.test.jsx 里引入的 [data-limit-group] 模式,另把一条「全文档无按钮」断言收窄到 Reset Bank 区块。合并后本 PR 即可转绿:目标文件 13/13、全量 520 过/4 失败(那 4 个在我机器的基线上同样失败,属环境问题)、lint 干净。

直接合并、cherry-pick 或按你的思路改都欢迎 🙏

@Hu9956
Hu9956 merged commit 6384afc into Hu9956:feat/subscription-manager Aug 25, 2026
1 check passed
@Hu9956

Hu9956 commented Aug 25, 2026

Copy link
Copy Markdown
Owner

Hi @LceAn, thanks again for this PR — it's been merged into feat/subscription-manager.

The subscription settings card redesign is the clear highlight — the wider two-column form and the scrollable popover feel much more comfortable to use. Really nice work there! All of it is fully retained in follow-up commit 1b7d3acf.

After reviewing everything against the live product, we did revert the UsageLimitsPanel provider list back to its previous styling and interaction (no bordered subscription rows, whole-row expand) — the new header-toggle look didn't land as well in daily use as we hoped. Nothing wrong with the implementation itself; it's a product-taste call on our side. We also appreciated the accessibility improvements (real <button> + aria-controls) and may revisit that direction later.


你好 @LceAn,再次感谢这个 PR——已合并进 feat/subscription-manager

订阅管理弹窗的改版是这次最大的亮点——加宽的双列表单和可滚动的弹层用起来舒服多了,做得真好!这部分在后续提交 1b7d3acf 中完整保留。

实机对比后我们将 UsageLimitsPanel 服务商列表退回了原来的样式与交互(订阅行不带边框、整行点击展开)——新的头部展开样式在日常使用中观感不如预期。实现本身没有问题,属于我们这边的产品取舍。你引入的无障碍改进(真正的 <button> + aria-controls)很受用,之后可能会重新采用这个方向。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants