fix: omit response_format from API request when it is None#546
Open
wudimenghuan wants to merge 1 commit intoHuanshere:mainfrom
Open
fix: omit response_format from API request when it is None#546wudimenghuan wants to merge 1 commit intoHuanshere:mainfrom
wudimenghuan wants to merge 1 commit intoHuanshere:mainfrom
Conversation
When api.llm_support_json is False, response_format was set to None but still included in the request body as "response_format": null. Some OpenAI-compatible API providers try to parse this field and access null.type, causing a 400 error: "Cannot read properties of null (reading 'type')" Now response_format is only included in params when it is not None.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
api.llm_support_jsonisFalse,response_formatwas set toNonebut still included in the API request body as"response_format": nullnull.type, causing a 400 error:"Cannot read properties of null (reading 'type')"Test plan
api.llm_support_jsontofalseand verify API requests no longer includeresponse_format: nullapi.llm_support_jsontotrueand verifyresponse_format: {"type": "json_object"}is still sent correctly