Updates PDF.js to latest 5.x version #6569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: To move closer to the maintained version
Why: bug fixes & improvements like creation of hyperlinks, improved rendering of large pages & JPEG2000 support
…es without gamepad Why: An error would be thrown, preventing a clean exit from VR mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates PDF.js to latest 5.x version
Why?
bug fixes & improvements like creation of hyperlinks, improved rendering of large pages & JPEG2000 support
How to test
NOTE: paging doesn't work in VR currently: #4951
Documentation of functionality
No changes to documentation
Limitations
The paging-in-VR bug is a distinct change
Additional details or related context
This could be merged before or after a paging-in-VR bugfix: #5427