Conversation
|
retest this please |
| } | ||
|
|
||
| File barcoded_bam = select_first([AttachBarcodes.bam_output, AttachBarcodesNoIndex.bam_output]) | ||
| Array[File] fastqc_output_htmls = select_first([FastQC.fastqc_htmls,FastQCNoIndex.fastqc_htmls]) |
There was a problem hiding this comment.
If you are expecting multiple zips or htmls then I think select_all() would be better here.
There was a problem hiding this comment.
Since only one of FastQC and FastQCNoIndex will ever be run, using select_all() would just result in an extra unnecessary level of array.
pipelines/optimus/Optimus.wdl
Outdated
| Array[File]? zarr_output_files = OptimusZarrConversion.zarr_output_files | ||
|
|
||
| # fastqc | ||
| Array[Array[File]] fastqc_htmls = fastqc_output_htmls |
There was a problem hiding this comment.
Unless you really want Array[Array[File]] here it seems like you'd be better off with flatten(fastqc_output_htmls)
test/optimus/pr/ValidateOptimus.wdl
Outdated
| fail=true | ||
| fi | ||
|
|
||
| for htmlfile in ${sep=' ' fastqc_htmls}; do |
There was a problem hiding this comment.
I guess you can't easily check the zips here? The test could at least assert that the number of zip files generated is correct.
|
@kbergin do we want to finish work on this? |
|
I've made a ticket for us to rebase this and get these changes reviewed and merged in. |
5 participants
Purpose
QA Inputs in SS2 and Optimus (and any future pipeline using fastqs as input)
Changes
Added FastQC task. For increased speed FastQC is run on only a subset of the fastq reads (can be set by inputs to task).