Security: Unsanitized XML construction allows label-config injection#803
Open
tomaioo wants to merge 1 commit intoHumanSignal:masterfrom
Open
Conversation
…ig i `generate_label_config` interpolates `categories` and `tags` values directly into XML attributes and elements without escaping. If inputs are user-controlled, crafted values can break XML structure or inject malicious markup that may trigger downstream parsing/UI issues. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Unsanitized XML construction allows label-config injection
Problem
Severity:
Medium| File:src/label_studio_sdk/converter/imports/label_config.py:L15generate_label_configinterpolatescategoriesandtagsvalues directly into XML attributes and elements without escaping. If inputs are user-controlled, crafted values can break XML structure or inject malicious markup that may trigger downstream parsing/UI issues.Solution
Escape XML-sensitive characters for all interpolated values (e.g., via
xml.sax.saxutils.escape/ quoteattr) or construct XML via a safe XML builder library rather than string replacement.Changes
src/label_studio_sdk/converter/imports/label_config.py(modified)