-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat: BROS-594: Add Distribution row to Task Summary #8821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It displays aggregations for choices, taxonomies, etc.: - For number and rating it shows average number - For choices, labels and taxonomies it shows counts for every option Also a lot of styles were fixed in Task Summary.
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8821 +/- ##
===========================================
- Coverage 66.72% 58.50% -8.22%
===========================================
Files 811 554 -257
Lines 63432 40207 -23225
Branches 10690 10761 +71
===========================================
- Hits 42325 23524 -18801
+ Misses 21104 16679 -4425
- Partials 3 4 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/git merge
|
…gnal/label-studio into fb-bros-594/summary-distribution
|
/fmt |
If there are no annotations don't fail trying to save the draft
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we not have a similar Badge component in the UI lib which could be used here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Chip has its own display logic. We might use Badge as display component inside Chip, but styles are different, we work on this later with @ricardoantoniocm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly it seems like we have many ways we handle color cycling for labels, it might be worthwhile consolidating the logic to a shared core util so everywhere we ever need this label cycling, it is the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea in general, but we have different logic for labels. Plus it uses outdated libraby we don't control, so it would be a nice effort to make all this controllable and consolidated, but definitely not in this PR.
- Move all code to one dedicated file - Don't show horizontal scroll on small tables - Don't show expand button for small aggregations - Simplify code a little
We should only apply it to schema/tags.json
|
/git merge
|
Aggregation/Distribution
It displays aggregations for choices, taxonomies, etc.:
Styles
A lot of styles were fixed in Task Summary: badges, table design, zebra rows, sticky column, usernames, etc.
Autoselect of Summary tab
When you switch between tasks you'll end up in the same pane you've been before — either annotation view, Summary tab or Compare tab. It makes it easier to review multiple tasks.
We already had a memory about a tab in View All, but now we also remember was it annotation view or View All. Technically it's tricky because we exit View All in a lot of places where we select annotation. And we select all annotations (or one with FF_SIMPLE_INIT on) on LSF init, so it always resets the view. So now we only exit View All if we are already in View All and do an interaction with UI.