Skip to content
This repository was archived by the owner on Mar 20, 2025. It is now read-only.

Conversation

@guijunchen
Copy link

Signed-off-by: Guijun Chen [email protected]

Type of change

  • Bug fix
  • New feature
  • Improvement (improvement to code, performance, etc)
  • Test update
  • Documentation update

Description

Additional details

Related issues

@davidkhala
Copy link
Member

@SamYuan1990 @davidkhala

@SamYuan1990
Copy link
Member

SamYuan1990 commented Sep 21, 2021

add comments in #13, with to do

in general, for short, we may?

  • make a new package named gm for all gm impls.
  • make gm as same level as sw.
  • adding test for gm package.

further considering,
for coding block as

switch key.type...
// should we instead this by a reg, which reg the types in to a container (map/array etc)
// and for _,v := range the container {
//. if key == v
//}

but limited with golang build.

for const, we can move into a new package?
for others as key import, as we put in a new package, we can impl in the package instead of modify existing?

@SamYuan1990
Copy link
Member

we will offline discuss it on next gm group regular meeting.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants