First refactor for Junit5 tests #1069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restructure the test framework to eliminate duplicate test classes and use parameterized class testing. This change consolidates various tests associated with the former BaseTestAES into a single parameterized test. Created new test suite package ibm.jceplus.junit.suites. New suites make use of Junit tags / groups to find tests to run. Multithreaded tests now are also executed and found using tags. Created test package ibm.jceplus.junit.tests this package contains all tests migrated to the new paramaterized format. Tests that have been converted have been removed. A new BaseTest abstract class for common functions was added based upon the old Junit5BaseTest. Created a TestArguments utility for generating test parameter variations that can be used in classes. This allows for tests to have dynamic variations based upon the group tag. Modified pom.xml to support new test suites. Tests will be migrated to the new suites and eventually older suites removed. Updated the README.md to reflect the groups option now available. Back-ported from: IBM#1051 Signed-off-by: Jason Katonica <[email protected]>
jasonkatonica
requested review from
JinhangZhang,
KostasTsiounis,
johnpeck-us-ibm and
taoliult
johnpeck-us-ibm
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructure the test framework to eliminate duplicate test classes and use parameterized class testing. This change consolidates various tests associated with the former BaseTestAES into a single parameterized test.
Created new test suite package ibm.jceplus.junit.suites. New suites make use of Junit tags / groups to find tests to run. Multithreaded tests now are also executed and found using tags.
Created test package ibm.jceplus.junit.tests this package contains all tests migrated to the new paramaterized format. Tests that have been converted have been removed. A new BaseTest abstract class for common functions was added based upon the old Junit5BaseTest.
Created a TestArguments utility for generating test parameter variations that can be used in classes. This allows for tests to have dynamic variations based upon the group tag.
Modified pom.xml to support new test suites. Tests will be migrated to the new suites and eventually older suites removed.
Updated the README.md to reflect the groups option now available.
Back-ported from: #1051
Signed-off-by: Jason Katonica [email protected]