-
Notifications
You must be signed in to change notification settings - Fork 381
Allow upload of CA certs for self signed certificate use #1383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,990
β336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78ca19a to
5a13b71
Compare
This was
linked to
issues
Nov 5, 2025
7 tasks
7 tasks
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
Signed-off-by: Madhav Kandukuri <[email protected]>
- Fix imports: mcpgateway.models -> mcpgateway.common.models - Add missing ToolHookType import - Update plugin manager API: tool_pre_invoke -> invoke_hook with ToolHookType - Update plugin manager API: tool_post_invoke -> invoke_hook with ToolHookType - Update HttpHeaderPayload: headers -> root parameter - Create alembic merge migration for CA cert and observability heads - Apply pre-commit formatting fixes (trailing whitespace, tabs, encoding pragma) Signed-off-by: Mihai Criveti <[email protected]>
Signed-off-by: Mihai Criveti <[email protected]>
7743e2a to
7d439f4
Compare
crivetimihai
approved these changes
Nov 8, 2025
Signed-off-by: Mihai Criveti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
β¨ Feature / Enhancement PR
π Epic / Issue
Link to the epic or parent issue:
Closes #1278, #1287, #1364
π Summary (1-2 sentences)
Adds first-class support for self-signed TLS by allowing users to upload a custom CA certificate. The CA is wired through gateway create/update flows, health checks, and tool calls, with UI-side file validation and updated docs.
π§ͺ How to Test This Feature
Quick Setup
Get your CA certificate file - If your MCP server uses a self-signed certificate, you'll need the CA certificate file (usually named something like
cert.pem,ca.pem,ca.crt, orrootCA.pem)Open the MCP Gateway Admin Panel - Navigate to your gateway instance and log in as an admin
Testing Steps
Step 1: Add a New Gateway with CA Certificate
My Test Serverhttps://your-mcp-server.example.com(must be HTTPS).pem,.crt,.cer, or.cert) into the upload area, or click to browseStep 2: Verify the Connection Works
Step 3: (Optional) Test Multiple Certificate Files
If you have a certificate chain (root + intermediate CAs):
What You Should See
β Success indicators:
β If something's wrong:
Need Help?
If you encounter issues:
docs/docs/manage/self-signed-certificates.mdπ§ͺ Checks
make lintpassesmake testpassesdocs/docs/manage/self-signed-certificates.md)