Skip to content

[Fix] UI 0047403: HTML validator: Use role='group' for tree-containing slates#11244

Open
fhelfer wants to merge 2 commits intoILIAS-eLearning:release_11from
fhelfer:ui/mantis/47403
Open

[Fix] UI 0047403: HTML validator: Use role='group' for tree-containing slates#11244
fhelfer wants to merge 2 commits intoILIAS-eLearning:release_11from
fhelfer:ui/mantis/47403

Conversation

@fhelfer
Copy link
Contributor

@fhelfer fhelfer commented Mar 11, 2026

Problem: The UI Component documentation tool window triggered HTML validator errors: role="tree" and role="treeitem" are not allowed inside role="menu" (only menuitem, menuitemcheckbox, etc. are valid).

Solution:

  • Add role="group" as an allowed ARIA role for Slates (valid container for tree content)
  • Switch UI Component documentation from Tool to TreeTool so it uses the TreeToolItemRenderer
  • TreeToolItemRenderer sets role="group" on its slate
  • Main Bar Renderer no longer overwrites an existing ARIA role on slates

https://mantis.ilias.de/view.php?id=47403

@oliversamoila
Copy link
Contributor

Hello @thibsy,
Could you please take this over directly, check it and, ideally, integrate it into Release 11 and Trunk. You will also need to decide whether Release 10 is applicable.

Best regards,
Oliver

@thibsy thibsy added the php Pull requests that update Php code label Mar 11, 2026
Copy link
Member

@chfsx chfsx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in GS are fine, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix kitchen sink php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants