Skip to content

Upgrade DOSDP Tools to 0.20#1347

Merged
matentzn merged 2 commits into
masterfrom
dosdp-tools020
Jun 11, 2026
Merged

Upgrade DOSDP Tools to 0.20#1347
matentzn merged 2 commits into
masterfrom
dosdp-tools020

Conversation

@matentzn

@matentzn matentzn commented May 20, 2026

Copy link
Copy Markdown
Contributor

Still testing this.

@gouttegd

Copy link
Copy Markdown
Contributor

Note that, with the switch to ODK-Core, the test suite in this repo only runs a small fraction of the existing tests.

If you want to run the full test suite with DOSDP Tools 0.20, you must add it to ODK-Core (here), and then run ODK-Core’s test suite (either locally, or on GitHub after creating a PR).

@matentzn

matentzn commented May 21, 2026

Copy link
Copy Markdown
Contributor Author

Note that, with the switch to ODK-Core, the test suite in this repo only runs a small fraction of the existing tests.

I didnt realise there were ANY tests for DOSDP tools? I have already tested it with 4 repos (OBA, Mondo, ECTO, DPO) - so I am not too concerned. But a single place to maintain the DOSDP version - which is it?

@gouttegd

Copy link
Copy Markdown
Contributor

I didnt realise there were ANY tests for DOSDP tools?

I think there are a couple of test configs that do make use of DOSDP. But of course, as for all our tests, we merely check that we can generate the repository and run a make_release workflow – we do not actually check that the tools behave as they should.

But a single place to maintain the DOSDP version - which is it?

The way things work for now is that ODK-Core can install the tools itself, but the build process for the ODK images will override ODK-Core.

So there are two places where the version of DOSDP-Tools can be specified, but the one place that gives the version that will end up in the actual ODK image is the one that you modified in this repository.

@gouttegd gouttegd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preemptive approval. @matentzn Feel free to merge whenever you are happy that you’ve done enough testing.

@Clare72

Clare72 commented May 25, 2026

Copy link
Copy Markdown
Contributor

Looks good from testing dpo and FBbt

@aleixpuigb

Copy link
Copy Markdown

Looks good from testing in OBA

@matentzn matentzn marked this pull request as ready for review June 11, 2026 13:34
@matentzn matentzn requested a review from gouttegd June 11, 2026 13:34
@matentzn matentzn merged commit fc9c0dc into master Jun 11, 2026
1 check passed
@matentzn matentzn deleted the dosdp-tools020 branch June 11, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants