Repository navigation
Conversation
Drop the "Prepare metadata" stage and only use the "docker/metadata-action". This is possible as no backports or the like are necessary here. Suffix the Debian version instead of prefixing, following conventions. Furthermore, make the base container name configurable for the test image, and add a big warning to the README.
julianbrost
left a comment
julianbrost
left a comment
There was a problem hiding this comment.
Looks fine in general, just two places that are probably more questions where I'd like a quick confirmation/explanation.
| flavor: | | ||
| # Disable automatic 'latest' tagging as our custom logic is used to | ||
| # determine when to apply the 'latest' tag. | ||
| latest=false |
There was a problem hiding this comment.
Now the removal of this comment slightly confuses me. The reason why this was set is gone, but you keep the setting as-is. Not sure if that was intentional or an oversight.
| tags: | | ||
| type=edge,prefix=${{ matrix.debian_version }}- | ||
| type=semver,pattern={{version}},prefix=${{ matrix.debian_version }}- | ||
| type=semver,pattern={{major}}.{{minor}},prefix=${{ matrix.debian_version }}- | ||
| type=semver,pattern={{major}},prefix=${{ matrix.debian_version }}-,enable=${{ env.LATEST_MAJOR }} | ||
| type=raw,value=${{ matrix.debian_version }},enable=${{ env.LATEST }} | ||
| type=raw,value=${{ matrix.debian_version }},enable=${{ github.event_name == 'release' && !github.event.release.prerelease }} | ||
| type=semver,pattern={{version}},suffix=-${{ matrix.debian_version }} | ||
| type=edge,suffix=-${{ matrix.debian_version }} |
There was a problem hiding this comment.
So compared to the different version labels I can currently see on https://github.com/Icinga/icinga2-plugins-container/pkgs/container/icinga2-plugins-container (0, 0.2, 0.2.0), those would be reduced back to only the full version (0.2.0)?
If so, that sounds reasonable. In the end, practically only the tags like trixie will be used, so if we can cut down additional complexity, great.
Drop the "Prepare metadata" stage and only use the "docker/metadata-action". This is possible as no backports or the like are necessary here.
Suffix the Debian version instead of prefixing, following conventions.
Furthermore, make the base container name configurable for the test image, and add a big warning to the README.
Fixes #4.
This does not seem to be possible with the
docker/build-push-actionaction, but since a local build cache should be used, I don't see much harm in doing so.