Flatten nulls to empty string for preg_match in PropertyModifierRejectOrSelect #2994
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In recent versions of PHP,
preg_match()will throw a deprecation notice if null is passed as its$subjectstring parameter. This change makesmatchesRegexp()behave as it would have before when a null was implicitly casted, and is probably what admin users would expect when testing their patterns against a non-existant value versus an empty value.