Skip to content

Work around lldb python issues #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Work around lldb python issues #91

wants to merge 1 commit into from

Conversation

@justinmichaud
Copy link
Collaborator

@justinmichaud justinmichaud commented Jan 22, 2025

This allows the python installation to work with lldb scripts in the WebKit repo, like dump-class-layout.

@justinmichaud justinmichaud mentioned this pull request Jan 28, 2025
Merged
TingPing
TingPing requested changes Feb 17, 2025
View reviewed changes
scripts/container-only/.wkdev-init
user_home=$(getent passwd "${container_user_name}" | cut -d: -f6)

sudo apt install lsb-release wget software-properties-common gnupg -y
wget -qO - https://apt.llvm.org/llvm.sh | sudo bash -s 19 -y
Copy link
Member

@TingPing TingPing Feb 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Installing core packages doesn't belong in .wkdev-init, it would go in the dockerfile.
  2. Downloading and installing the entire llvm toolchain is a pretty massive change... Can you not get Ubuntu's LLVM 18 working?

FWIW, I use the LLDB integration in VSCode every day without issue.

Copy link
Member

@nikolaszimmermann nikolaszimmermann Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, we should try to use the LLVM bundled with Ubuntu and find out the root cause of the issue. @justinmichaud wdyt?

@justinmichaud
Copy link
Collaborator Author

justinmichaud commented Oct 15, 2025

The root cause is a missing symlink:

sudo apt install python3-lldb-20
sudo cp /usr/lib/llvm-20/lib/python3.12/site-packages/lldb/../../../liblldb.so.1 /usr/lib/llvm-20/lib/python3.12/site-packages/lldb/../../../liblldb.so
PYTHONPATH="/usr/lib/llvm-20/lib/python3.12/site-packages/:$PYTHONPATH" linux32 python3 Tools/Scripts/dump-class-layout -t WebKitBuild/JSCOnly/Debug/lib/libJavaScriptCore.so JavaScriptCore JSC::JSCell

works

@nikolaszimmermann
Copy link
Member

nikolaszimmermann commented Oct 23, 2025

Can you update the PR @justinmichaud so we can merge it with the symlink fix instead? Can be done in the Containerfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikolaszimmermann nikolaszimmermann nikolaszimmermann left review comments

@TingPing TingPing TingPing requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@justinmichaud @nikolaszimmermann @TingPing