Skip to content

Check NULL values in String utilities #1933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Check NULL values in String utilities #1933

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 21 additions & 11 deletions app/src/common/shared/com/igalia/wolvic/utils/StringUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,8 @@

import androidx.annotation.NonNull;

import com.igalia.wolvic.R;

import java.text.SimpleDateFormat;
import java.util.Calendar;
import java.util.GregorianCalendar;
import java.util.Locale;
import java.util.Objects;

public class StringUtils {
static final String LOGTAG = SystemUtils.createLogtag(StringUtils.class);
Expand All @@ -26,7 +22,10 @@ public static String getStringByLocale(Context context, int id, Locale locale) {
return context.createConfigurationContext(configuration).getResources().getString(id);
}

public static String removeSpaces(@NonNull String aText) {
public static String removeSpaces(String aText) {
if (isEmpty(aText)) {
return "";
}
return aText.replaceAll("\\s", "");
}

Expand Down Expand Up @@ -54,7 +53,10 @@ public static String removeLastCharacter(String aText) {
return "";
}

public static String removeRange(@NonNull String aText, int aStart, int aEnd) {
public static String removeRange(String aText, int aStart, int aEnd) {
if (isEmpty(aText)) {
return "";
}
String start = "";
if (aStart > 0) {
start = aText.substring(0, aStart);
Expand All @@ -67,21 +69,29 @@ public static String removeRange(@NonNull String aText, int aStart, int aEnd) {
}

public static boolean contains(String[] aTarget, String aText) {
if (aTarget == null) {
return false;
}
for (String str: aTarget) {
if (str.equals(aText)) {
if (Objects.equals(str, aText)) {
return true;
}
}

return false;
}

public static long charCount(@NonNull String aString, char target) {
public static long charCount(String aString, char target) {
if (isEmpty(aString)) {
return 0;
}
return aString.chars().filter(ch -> ch == target).count();
}

@NonNull
public static String capitalize(@NonNull String input) {
public static String capitalize(String input) {
if (isEmpty(input)) {
return "";
}
try {
return input.substring(0, 1).toUpperCase() + input.substring(1);
} catch (StringIndexOutOfBoundsException e) {
Expand Down
Loading