Enable WebXR support in WPE WebKit #81
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a recipe for the latest version of the OpenXR SDK.
Toggle ENABLE_WEBXR and add the needed dependency on the "openxr" recipe. Define XR_USE_PLATFORM_ANDROID when targeting Android.
aperezdc
force-pushed
the
aperezdc/enable-webxr
branch
from
54df19c to
1e3ab4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes two commits: one adds a new
openxrbuild recipe, for the OpenXR SDK; the other makes the needed changes to actually enable WebXR support in thewpewebkitrecipes.Note that I would recommend merging this after #80 even if the code builds with 2.48.x, because the WebXR support in 2.50.x is considerably improved.
Important: the WebXR support has been tested with additional patches from the
mainbranch of WebKit applied on top of 2.50.0, so this may build but not actually run. The idea of this PR is to show what's needed. My plan is to keep the WebXR support disabled in the stable 2.50 branch (to be created after #80 is merged) and only then make themainbranch build against snapshots built from the WebKitmainbranch.