Merged
Conversation
Operator headers now live at `<platform>/ops/<op>/<file>.h` instead of `<platform>/<op>/<file>.h`, so the platform name is one level deeper.
…sion with framework `runtime.h` The shared CUDA scaffolding header `cuda/runtime.h` defines the `CudaRuntime` CRTP base, which inherits from `DeviceRuntime` declared in the framework-level `runtime.h`. Bringing the framework header in via `#include "../runtime.h"` violates the Google C++ Style Guide's prohibition on relative include paths, and rewriting to `#include "runtime.h"` instead self-references because quoted includes search the current file's directory first. Renaming the file to `runtime_.h` matches the trailing-underscore convention used by every other platform-internal scaffolding header (`device_.h`, `data_type_.h`, `caster_.h`, etc.) and removes the collision so `#include "runtime.h"` resolves to the framework header through the project include path. Update the four sub-platform `runtime_.h` files that include it accordingly.
Ziminli
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.