feat(run): add --no-skills opt-out - #364
Open
bferanmi806-sketch wants to merge 1 commit into
Open
Conversation
|
✅ CLA satisfied. All contributors have signed the current CLA. The |
bferanmi806-sketch
marked this pull request as ready for review
August 6, 2026 15:54
Contributor
|
| Filename | Overview |
|---|---|
| cmd/run.go | Adds the shared flag and correctly limits its effect to host-mode skill installation while leaving OpenClaw configuration reachable. |
| cmd/run_test.go | Verifies both command forms expose the flag and confirms enabled and disabled filesystem behavior. |
| docs/reference/cli.mdx | Documents the new flag, default value, and host-mode scope consistently with the implementation. |
| docs/quickstart/openclaw.mdx | Clarifies that the opt-out skips skill writes but does not disable OpenClaw proxy configuration. |
Reviews (1): Last reviewed commit: "feat(run): add skill installation opt-ou..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #338
Adds a shared
--no-skillsoption to bothagent-vault runandagent-vault vault run.--no-skills, the skill file is not created or modified.--no-skillsis supplied.Type of change
Test plan
make test): the suite reaches all packages but the existinginternal/isolation.TestAssetsHash_Stableassertion fails (got 530f92080947,want 0cf46302069b); no isolation asset files are changed here.--no-skillswith the expected help text)Validation:
gofmt -w cmd/run.go cmd/run_test.gopassed with Go 1.25.go test ./cmd -count=1passed.go test ./... -count=1reached all packages and has only the pre-existing isolation asset-hash failure described above.go vet ./...passed.git diff --checkpassed with native Windows Git.make testreproduces the same pre-existing isolation asset-hash failure.make lintwas attempted but could not start becausegolangci-lintis not installed; the frontend TypeScript step was not reached.Security checklist