Skip to content

Conversation

@jansimonb
Copy link
Contributor

@jansimonb jansimonb commented Dec 2, 2025

Proposed Changes

Add option to disable gRPC response compression for Flight queries:

  • disable_grpc_compression parameter in InfluxDBClient3 constructor
  • INFLUX_DISABLE_GRPC_COMPRESSION environment variable support in from_env()

Testing

  • Unit tests added
  • Integration test added that checks the request/response headers of the grpc communication to verify that the returned query response is really compressed. To achieve this a lightweight HTTP/2 proxy had to be added for testing purposes (h2_proxy.py).
  • NOTE: InfluxDB 3 Core may not compress responses even when client advertises gzip support. Per gRPC spec, servers may choose not to compress regardless of client settings. InfluxDB Cloud typically compresses, but Core may not. For that reason it is recommended to run the integration test also against InfluxDB Cloud.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.05%. Comparing base (fac1793) to head (7bf88f7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
+ Coverage   69.73%   70.05%   +0.32%     
==========================================
  Files          35       35              
  Lines        2333     2348      +15     
==========================================
+ Hits         1627     1645      +18     
+ Misses        706      703       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jansimonb jansimonb marked this pull request as ready for review December 3, 2025 10:33
Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants