Skip to content

chore/rfq-update#666

Merged
ThomasRalee merged 1 commit into
masterfrom
chore/rfq-update
May 15, 2026
Merged

chore/rfq-update#666
ThomasRalee merged 1 commit into
masterfrom
chore/rfq-update

Conversation

@Frederick-88
Copy link
Copy Markdown
Collaborator

@Frederick-88 Frederick-88 commented May 15, 2026

Summary by CodeRabbit

  • New Features

    • Added maker authentication support for RFQ maker streams.
    • Added taker nonce time window configuration for conditional orders.
  • Removals

    • Removed submitRequest and submitQuote methods from the RFQ API.
  • Chores

    • Updated indexer protocol dependency to version 1.18.20.

Review Change Stack

@ThomasRalee ThomasRalee merged commit 9b4efbe into master May 15, 2026
4 of 5 checks passed
@ThomasRalee ThomasRalee deleted the chore/rfq-update branch May 15, 2026 14:59
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This PR updates the Injective RFQ SDK with three main changes: a protobuf dependency bump from 1.18.18 to 1.18.20, removal of the deprecated submitRequest and submitQuote methods from the IndexerGrpcRFQApi, addition of an optional takerNonceTimeWindowMs field to conditional orders, and a new maker authentication challenge-response flow for WebSocket streams involving new RFQMakerAuth and RFQMakerChallenge types plus corresponding codec and stream handlers.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is vague and generic, using a non-descriptive pattern that doesn't convey the actual changes made in the pull request. Consider a more descriptive title such as 'refactor RFQ API: remove submitRequest/submitQuote and add maker auth' to better communicate the main changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/rfq-update

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants