Potential fix for code scanning alert no. 665: Comparison result is always the same #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lways the same Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/IntelLabs/HEC-openfhe-development-test/security/code-scanning/665
The best way to fix this issue is to remove the always-false condition and the associated exception. The line
if (logc < 0) { OPENFHE_THROW("Too small scaling factor"); }can simply be deleted, aslogccan never be negative. No additional error checking is required, since a scaling factor that really is "too small" (i.e., all values are zero) simply results inlogc==0, which is handled safely by the rest of the code. The logic and functionality remain unchanged for all valid and invalid inputs, except that the dead code is eliminated.Suggested fixes powered by Copilot Autofix. Review carefully before merging.