Potential fix for code scanning alert no. 35: Multiplication result converted to larger type #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/IntelLabs/HEC-openfhe-development-test/security/code-scanning/35
To fix the problem, the multiplication should be performed using the larger integer type so that if the result would exceed the range of a 32-bit unsigned integer, the correct (unwrapped) value will be produced. The best way to achieve this is to cast one of the operands (
bSteporj) tosize_torstd::vector<>::size_typebefore doing the multiplication, so that the multiplication will be promoted to the larger type. Update all instances ofbStep * jthat index into vectors or are used as arguments requiring larger types to use the cast.For the code in question, change line 1608:
to:
You may similarly want to update the subsequent uses (e.g.,
A[bStep * j + i],FindAutomorphismIndex2nComplex(bStep * j, M)) for consistency and safety, but only the highlighted multiplication needs fixing per the error report.No new methods, imports, or external dependencies are required.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.